Enable the object-shorthand ESLint rule in web
#8351
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4e510e73d4202fe/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4e510e73d4202fe/output.txt Total script time: 1.57 mins Published |
web/hand_tool.js
Outdated
| onActiveChanged: function(isActive) { | ||
| this.eventBus.dispatch('handtoolchanged', {isActive: isActive}); | ||
| }.bind(this) | ||
| onActiveChanged(isActive) { |
There was a problem hiding this comment.
It looks like this change breaks the hand tool menu item in the secondary toolbar. Toggling the hand tool does work, but the menu no longer disappears after toggling and the text is not updated anymore. I'm also not sure if this is bound correctly without bind(this) in this case.
There was a problem hiding this comment.
D'oh, this is a really stupid mistake on my part; thanks for spotting it!
I've updated the code to an arrow function, which is what it should have been from the start.
Please see http://eslint.org/docs/rules/object-shorthand. For the most part, these changes are of the search-and-replace kind, and the previously enabled `no-undef` rule should complement the tests in helping ensure that no stupid errors crept into to the patch.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/43b85e35b180be0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/43b85e35b180be0/output.txt Total script time: 1.57 mins Published |
|
Thank you! |
…thand-web Enable the `object-shorthand` ESLint rule in `web`
Since we're using Babel, it's now possible for us to use the more compact object notation available in ES6 (see this MDN article).
Please see http://eslint.org/docs/rules/object-shorthand; this is one of the rules mentioned in issue #7957.
Note: I initially created one big patch for this change, see master...Snuffleupagus:eslint-object-shorthand, but after looking at the diff I quickly realized that it was too big and I don't think anyone would want to review that. Hence I've decided to split it up into more manageable chunks instead.